cmu-lib / archive_plugin

Janeway plugin for managing journal archiving.
MIT License
8 stars 2 forks source link

populate authors, keywords when beginning article revision #20

Closed mdlincoln closed 5 years ago

mdlincoln commented 5 years ago

Closes https://github.com/dSHARP-CMU/cmesh-dev/issues/328 Closes https://github.com/dSHARP-CMU/cmesh-dev/issues/334

note that this imports copy so that the original_article instance is preserved and its m2m relations for authors, articleauthororder_set, and keywords are preserved for copying into the new article

mdlincoln commented 5 years ago

See also https://github.com/dSHARP-CMU/cmesh-dev/issues/334 - also try to associate images with new revision?

hachacha commented 5 years ago

The authors and keywords in the beginning look good. Will wait on merging this until there's an answer on unlinking or editing article-associated images.

mdlincoln commented 5 years ago

I've nulled out article images. If this looks good, please merge and then I can start a revamp of the is_archived logic for #19 which will probably include more changes to this. But then at least even if we take longer on #19 we'll have this main bug fixed.

hachacha commented 5 years ago

all good.