search

cmu-lib / bridgesofPittsburgh

Code and documents associated with the Bridges of Pittsburgh DH project at CMU
7 stars 2 forks source link

fine-tune bridge centroid set and render to leaflet #121

Closed mdlincoln closed 5 years ago

mdlincoln commented 5 years ago

I've exported the estimated centroids for bridges as a set of points with a few attributes for their popups to osmar/output_data/bridge_centroid_sf.rda. To-do by @ERSlayton:

  1. manually fix centroid locations for complicated/curving bridges in e.g. arcmap (I know that'll mean needing to write out this sf object as a shapefile or something - lmk if you prefer I upload it in another fomrat)
  2. commit manually-checked point data into repo
  3. render onto Leaflet map

since this requires a manual step, we should hold off on finishing it until we are 100% satisfied with the data, pathways, etc.

ERSlayton commented 5 years ago

I made the map from the osmar/output_data/bridge_centroid_sf.rda file. Will upload to wordpress shortly.

Bridges_ex

ERSlayton commented 5 years ago

However, as you said, we may need to manually adjust the frame? How is the progression on this decision making?

mdlincoln commented 5 years ago

@ERSlayton are you referring to the full-screen wordpress theme @scottbot is looking for? #112 or something else?

mdlincoln commented 5 years ago

@ERSlayton I'm about to push the data for the river-bridges-only pathway that I've computed. Since the underlying road data is identical, it's just the pathway that's changed, I suggest that you just subset the full bridge centroids that you're hand-fine-tuning, just to contain the river bridges only.

Alternatively I can produce a new set of centroids - but then you'd need to hand-fine-tune that set again. Do you have a preference?

ERSlayton commented 5 years ago

Hello Matt,

I would say just go ahead and make a new set of centroids. I haven’t been able to move very far in adapting them, so any changes won’t put me to far behind.

All the best,

Emma

From: Matthew Lincoln notifications@github.com Sent: Tuesday, April 9, 2019 9:37:44 AM To: dSHARP-CMU/bridgesofPittsburgh Cc: Emma Slayton; Mention Subject: Re: [dSHARP-CMU/bridgesofPittsburgh] fine-tune bridge centroid set and render to leaflet (#121)

@ERSlaytonhttps://github.com/ERSlayton I'm about to push the data for the river-bridges-only pathway that I've computed. Since the underlying road data is identical, it's just the pathway that's changed, I suggest that you just subset the full bridge centroids that you're hand-fine-tuning, just to contain the river bridges only.

Alternatively I can produce a new set of centroids - but then you'd need to hand-fine-tune that set again. Do you have a preference?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/dSHARP-CMU/bridgesofPittsburgh/issues/121#issuecomment-481255032, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AjSabnhGAS2W4NsogPKZQGFOkN6IGvRGks5vfJeogaJpZM4bDtG5.