search

cmu-lib / bridgesofPittsburgh

Code and documents associated with the Bridges of Pittsburgh DH project at CMU
7 stars 2 forks source link

Optimize the single-Way bridge rewiring/smoothing function #39

Closed mdlincoln closed 6 years ago

mdlincoln commented 6 years ago

Right now this runs frustratingly slowly, and I suspect it may be doing lots of unnecessary work by simplifying single-Way bridges that don't need to be collapsed anyway. The only function this smoothing step serves is to simplify the eventual bridge collapsing. I'll introduce a check that skips those bridges we don't know need to be collapsed, which should result in significant speedup.

mdlincoln commented 6 years ago

I should probably just take the handler function I've written for rewiring a single bridge and call it within the larger function that maps across the graph to collapse multi-Way bridges. two birds with one stone 🐦 🐦

mdlincoln commented 6 years ago

it's unclear why, but this new code wants to eliminate the Warhol Bridge... 👎