search

cmu-lib / dhlg

The Digital Humanities Literacy Guidebook
https://cmu-lib.github.io/dhlg
MIT License
59 stars 27 forks source link

Issue with long ToC because of sticky topnav #92

Closed scottbot closed 5 years ago

scottbot commented 5 years ago

Another sticky topnav issue, the ToC is now getting cut off at the bottom of the page on desktop, without being able to access the content at the bottom of the list.

image

milnerm commented 5 years ago

this should max out at the available space, minus a margin at the bottom.

scottbot commented 5 years ago

I'm not sure why, but for me it's cutting off several list items below the page.

milnerm commented 5 years ago

Yeah, the window scroll calculation seems off. I think i've got it now. going to push revisions in a moment here.

scottbot commented 5 years ago

Weirdly, the problem is still happening when I refresh the page, though not always on first load. image image

mdlincoln commented 5 years ago

FWIW I haven't been able to reproduce this under Firefox 69.0

mdlincoln commented 5 years ago

OK, I can reproduce this in both Firefox and Safari. The issue in those browsers seems to be: on loading the site, if the vertical viewport is too small to show the entire ToC, it gets cutoff and no scroll bar is displayed. However, as soon as I manually resize my window (either to make it bigger OR smaller) then the CSS seems to kick in and the ToC gets appropriately resized & scroll-bar gets displayed.

screencast: https://cmu.box.com/s/occ3ykb7dr0mpdokhwj2j1oior55wm73

milnerm commented 5 years ago

fixed, sizing now occurs on page load as well as resize