cmu-mars / brasscomms

0 stars 1 forks source link

get pylint to run O(cleanly) #30

Closed ivoysey closed 7 years ago

ivoysey commented 7 years ago

(ish)

it cares about some stuff like spacing conventions that we can either ignore or build a style file for our own codebase and go from there. but it's a good idea more generally; we're currently in the rough according to its score, and it'll probably catch at least one stupid bug.

ivoysey commented 7 years ago

there are some outstanding issues that don't pass pylint. some of them i've decided to ignore by adding them to the .pylintrc file, like: broad exception catching because we're doing it for logging which is the right reason; some variable names that are out of spec for PEP8; etc.

problems that remain are mostly down to global variable usage, which i agree is a bad habit but feel forced into by the Flask API.

joshsunshine commented 7 years ago