cmu-phil / tetrad

Repository for the Tetrad Project, www.phil.cmu.edu/tetrad.
GNU General Public License v2.0
402 stars 110 forks source link

Some issues getting verbose output to work for algorithms. #1109

Closed jdramsey closed 5 years ago

jdramsey commented 5 years ago

Verbose output should work for the following algorithms if the verbose flag is set to true (some of these already work):

  1. PC (already works)

  2. FCI (already works)

  3. FGES

  1. FOFC

Also, the verbose flag should alway occur LAST in the list of parameters. Just need to go through and make this the case.

Also, make this version available to @cg09 and @ps7z so they can use it.

@cg09 @ps7z @mglymour Did I get everything?

jdramsey commented 5 years ago

Like I said, I believe 1 and 2 are good already. The problem was that before the verbose flag wasn't being passed into those algorithms, but that has now been fixed.

3 - I just spent 10 minutes changing all of the TetradLogger log commands to forcelog commands. This all seems to work now. I need to put these change in a a separate branch and do a pull request.

4 - I just fixed those logs so they all also get sent to the logging window. That work now.

OK, just need to make the verbose parameter always last. Give me a second. (Or do you guys want to do that?)

jdramsey commented 5 years ago

I marked some algorithms as for continuous data only: R3, Skew, RSkew, LiNGAM, GLASSO.

jdramsey commented 5 years ago

Just a note: In a couple of cases, the verbose parameter was coming up from another source and had to be removed from the list and re-added to get it to come out as last.

This all works now for me (I think). OK, I'll do the pull request.

yuanzhou commented 5 years ago

Addressed via #1110