search

cmu-phil / tetrad

Repository for the Tetrad Project, www.phil.cmu.edu/tetrad.
GNU General Public License v2.0
402 stars 110 forks source link

Make LiNGAM experimental. #1177

Closed jdramsey closed 5 years ago

jdramsey commented 5 years ago

it is still broken. This should not go into the next release unless it can be fixed.

noaholic commented 5 years ago

Everytime I perform a LiNGAM I get a different result for the same data.

jdramsey commented 5 years ago

Making this experimental in branch joe.work.2019.8

cg09 commented 5 years ago

The algorithms should have done a check for whether the data could be explained without latent variables. Madelyn wrote code for them to do it. I don't know if it ever got to github. Madelyn?

Clark

On Sat, Aug 17, 2019 at 5:18 PM Joseph Ramsey notifications@github.com wrote:

Making this experimental in branch joe.work.2019.8

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/cmu-phil/tetrad/issues/1177?email_source=notifications&email_token=AD4Y3OO54ZM74RKQIT4FYDDQFBTL5A5CNFSM4H5GAPIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4QTUQY#issuecomment-522271299, or mute the thread https://github.com/notifications/unsubscribe-auth/AD4Y3OLDMKK6XE65TSZ74PTQFBTL5ANCNFSM4H5GAPIA .

jdramsey commented 5 years ago

Actually, fixed the experimental tag in joe.few.changes.from.issues.

jdramsey commented 5 years ago

What is this check you speak of?

@cg09 @mglymour

cg09 commented 5 years ago

The check is to see if the tetrad constraints are entailed by vanishing partial correlations.

On Sat, Aug 17, 2019 at 5:43 PM Joseph Ramsey notifications@github.com wrote:

What is this check you speak of?

@cg09 https://github.com/cg09 @mglymour https://github.com/mglymour

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cmu-phil/tetrad/issues/1177?email_source=notifications&email_token=AD4Y3OKGQLFFPHNBUGJAQH3QFBWIZA5CNFSM4H5GAPIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4QT7UQ#issuecomment-522272722, or mute the thread https://github.com/notifications/unsubscribe-auth/AD4Y3ONVPW7TZBEDUVJ7XPLQFBWIZANCNFSM4H5GAPIA .