cmu-phil / tetrad

Repository for the Tetrad Project, www.phil.cmu.edu/tetrad.
GNU General Public License v2.0
404 stars 111 forks source link

Restore Mimbuild in the interface. #486

Closed jdramsey closed 7 years ago

jdramsey commented 7 years ago

In the config file, this bit of code needs to be uncommented:

        <model name="MIMBuild" acronym="MIMBuild" help="mimbuild"
               category="Multiple Indicator Model searches">
            <logger>
                <event id="info" description="Information" default="on"/>
                <event id="details" description="Misc Fine Details" default="on"/>
                <event id="maxmodel" description="Max P Value Model" default="on"/>
            </logger>
            <model-class>edu.cmu.tetradapp.model.MimBuildRunner
            </model-class>
            <editor-class>edu.cmu.tetradapp.editor.MimbuildEditor
            </editor-class>
        </model>
jdramsey commented 7 years ago

@yuanzhou @espinoj

Maybe there's a better interface for Mimbuild, but this one at least works. Here's a screenshot.

screen shot 2017-06-19 at 6 05 03 pm
jdramsey commented 7 years ago

Also, @ekummerfeld @ps7z

yuanzhou commented 7 years ago

@jdramsey Do I just uncomment the config section and test things out or is there anything specific you want me to look at?

jdramsey commented 7 years ago

@yuanzhou I think just uncomment it and try it out, as you say. It should just work; it was working before, and it worked for me just now. I thought it better if you did the honors though, so you weren't surprised.

yuanzhou commented 7 years ago

@jdramsey no problem. Since I'm also fixing another Tetrad bug, I may combine this issue and the one I'm working on in the same pull request later.

jdramsey commented 7 years ago

@yuanzhou Great, thanks!

yuanzhou commented 7 years ago

I was able to get the Mimbuild work. Also noticed the weird highlighting issue that we noticed int he knowledge tier box.

mim mm

@jdramsey for some reason, I could only get it work once. I tried several times later with multiple searches but just couldn't reproduce. What is the proper procedure to use the Mimbuild?

yuanzhou commented 7 years ago

For example, I created a data model and imported some data. Then PC search1, FGES search2. On search3, I was able to select "Mimbuild" but it pops up this:

capture

I think I'll need some instructions on how to use Mimbuild.

jdramsey commented 7 years ago

Try simulation first. In the Graph box make a random MIM, with four measures per latent, like this:

screen shot 2017-06-20 at 4 15 28 pm

Do a search, as follows:

screen shot 2017-06-20 at 4 17 57 pm

Then a measurement model box:

screen shot 2017-06-20 at 4 19 05 pm

Then add Mimbuild:

screen shot 2017-06-20 at 4 21 33 pm

This gives you a graph over the latents.

This is a little difficult to follow for a user; we may need to add an additional pipeline or two for it. Unless you can think of a better way to do it!

yuanzhou commented 7 years ago

Thanks @jdramsey! I also set the cluster selection to start at 3 with a upper limit of 100. It was showing 0 even though we have 3 clusters, and the upper limit was 1000, which I think is too big.

I'll send a pull request soon.

yuanzhou commented 7 years ago

I'm closing this since we've had Mimbuild restored in development branch now.