Added deep_clean method to CatkinInference and implemented CatkinMake (fixes #221)

cmu-rss-lab / roswire

A library for static and dynamic analysis of ROS applications via Docker 🔌

http://christimperley.co.uk/roswire

Apache License 2.0

8 stars 0 forks source link

Added deep_clean method to CatkinInference and implemented CatkinMake (fixes #221) #389

Closed afsafzal closed 4 years ago

afsafzal commented 4 years ago

@ChrisTimperley I added the deep_clean function to CatkinInterface. With this functionality I no longer need CatkinMake and I can simply just use CatkinTools, so if you think the repeated functionality is code smell I can return both build and clean back to raise NotImplementedError as before.

ChrisTimperley commented 4 years ago

Overall, the changes look nice. Just a few minor tweaks and then we're good to merge.

ChrisTimperley commented 4 years ago

We probably want to update the CHANGELOG here, too.