Open willeppy opened 3 years ago
This issue is fixed in the branch unit-test-implement
. Waiting to be examined and merged
This is almost complete, just need to fix a couple remaining things
================================================================================= short test summary info =================================================================================
FAILED tests/test_action.py::test_crosstab - pandas.core.indexing.IndexingError: Unalignable boolean Series provided as indexer (index of the boolean Series and of the indexed object d...
FAILED tests/test_performance.py::test_lazy_maintain_performance_census - AssertionError: Subsequent display of recommendations on Census dataset took a total of {delta2:0.4f} seconds,...
================================================================= 2 failed, 261 passed, 449 warnings in 542.63s (0:09:02) =================================================================
I think we also need to stub out the jupyter execution context so that we can run these tests from the command line before closing this out
Need to add tests for new functionality.
This requires two things
Files / functionality that need NEW unit tests:
frame.py
series.py
(same as above)groupy.py
(same as above)history.py
Clause.py
I added a mark_type parameter to make sure that column ends up as a vis with a certain mark type but haven't written tests to make sure this is actually enforced. Mostly means adding tests to compiler to make sure the clause results in visualizations that are of this mark typeimplicit_plotter.py
andcg_plotter.py
.df.describe()
is called it produces a box plot and the right history.Other files had small changes that are breaking existing tests. These tests should be amended to make sure that they are testing for good functionality and also comply with the changes.