cmudig / solas

Visualization Recommendation Based on Analysis History
MIT License
14 stars 3 forks source link

Add tests for history and Amend previous unit tests that are broken because of new changes #3

Open willeppy opened 3 years ago

willeppy commented 3 years ago

Need to add tests for new functionality.

This requires two things

  1. Edit the existing tests for lux to make sure they are accurate (many will not run now because I have made changes but did not change the tests)
  2. Add new tests for the new functionality we have added.

Files / functionality that need NEW unit tests:

Other files had small changes that are breaking existing tests. These tests should be amended to make sure that they are testing for good functionality and also comply with the changes.

leijie-wang commented 3 years ago

This issue is fixed in the branch unit-test-implement. Waiting to be examined and merged

willeppy commented 3 years ago

This is almost complete, just need to fix a couple remaining things

================================================================================= short test summary info =================================================================================
FAILED tests/test_action.py::test_crosstab - pandas.core.indexing.IndexingError: Unalignable boolean Series provided as indexer (index of the boolean Series and of the indexed object d...
FAILED tests/test_performance.py::test_lazy_maintain_performance_census - AssertionError: Subsequent display of recommendations on Census dataset took a total of {delta2:0.4f} seconds,...
================================================================= 2 failed, 261 passed, 449 warnings in 542.63s (0:09:02) =================================================================
willeppy commented 3 years ago

I think we also need to stub out the jupyter execution context so that we can run these tests from the command line before closing this out