search

cmulay / python-aio

You can now seek help on your current python project ! Drop discussion in QnA Section of this repo ! Below is the link for discussion.
https://github.com/cmulay/python-aio/discussions
Apache License 2.0
12 stars 12 forks source link

Is venv really required? #25

Closed mani-barathi closed 3 years ago

mani-barathi commented 3 years ago

Problem

venv folder in the root directory is increasing the size of the repo. Imagine the situation where a person clone's the repo for downloading a couple of projects, but because of the venv folder, they should download more than 100Mb which is not nice. And in most cases, people cloning the repo will have their own python installation on their computer

@cmulay what's your thought on this?

cmulay commented 3 years ago

thanks for bringing it to my attention. adding venv to .gitignore will solve this issue.

mani-barathi commented 3 years ago

Will you fix this or should I fix and make a PR

cmulay commented 3 years ago

I'll add it, thanks

cmulay commented 3 years ago

Hey @mani-barathi , I've added venv to .gitignore and to .gitexclude as well yet it doesn't seem to work. Can you have a look into it ?

mani-barathi commented 3 years ago

@cmulay I'll look into this

cmulay commented 3 years ago

Yes, thank you !