cmullaparthi / ibrowse

Erlang HTTP client
Other
516 stars 190 forks source link

Resolve hostnames over SOCKS5 #115

Closed rnewson closed 10 years ago

rnewson commented 10 years ago

Resolve hostnames via the SOCKS5 proxy if one is being used. This prevents anonymity leakage when using Tor.

cmullaparthi commented 10 years ago

Thanks Robert. Will this work if the input Host is an IP address such as "10.1.2.3" ? I don't have access to a SOCKS proxy to test.

rnewson commented 10 years ago

I will verify and update this ticket shortly.

rnewson commented 10 years ago

It appears your SOCKS5 support only applies to http not https requests.

rnewson commented 10 years ago

My changes to the ibrowse copy in couchdb supports both: https://github.com/apache/couchdb/commit/fcd76c9cd4b115165a9904d2894741222f3a575c.

Should I close this patch and open a more substantial one that includes all of that work?

cmullaparthi commented 10 years ago

That would be great.

rnewson commented 10 years ago

Closed in preference for https://github.com/cmullaparthi/ibrowse/pull/117.