search

cmullaparthi / ibrowse

Erlang HTTP client
Other
516 stars 190 forks source link

Proper lager usage #144

Closed lemenkov closed 8 years ago

lemenkov commented 8 years ago

Using lager:something(...) isn't possible w/o parse_transform. It must be added either into every erl-file or externally, into rebar.config (I prefer the latter option). So let's add it.

It wasn't detected previously since all lager invocations are guarded by catch clauses.

Signed-off-by: Peter Lemenkov lemenkov@gmail.com

cmullaparthi commented 8 years ago

Hi Peter,

Thank you for the pull request. I'm slightly embarrassed that I didn't notice the use of lager creep into the ibrowse code (it came in as part of a pull request in 2014 I think). I want to keep ibrowse dependency free, so will replace the lager invocation with some configurable option to invoke a {M, F} for logging such stuff.

lemenkov commented 8 years ago

Sure, sounds like a good idea! Still keep in mind that in case of lager it will likely require parse_transform. Just let's not reintroduce this again :)