search

cmullaparthi / ibrowse

Erlang HTTP client
Other
516 stars 190 forks source link

socks5 + ssl #150

Closed fshashin closed 8 years ago

fshashin commented 8 years ago

The problem: socks5 proxy settings ignored for SSL connections.

Example: next request ibrowse:send_req("http://www.google.com",[], get, [], [{socks5_host, "127.0.0.1"}, {socks5_port, 12345}]) will be send through proxy 127.0.0.1: 12345 as expected. But the same HTTPS request ibrowse:send_req("https://www.google.com",[], get, [], [{socks5_host, "127.0.0.1"}, {socks5_port, 12345}]) will be send directly to www.google.com

Decision: this commit upgrades socks5 proxy connection to SSL connection if needed.

fshashin commented 8 years ago

Sorry, just found out that this fix already exists: https://github.com/cmullaparthi/ibrowse/pull/145