cmullaparthi / ibrowse

Erlang HTTP client
Other
516 stars 190 forks source link

undefined functions ibrowse_test_server:start_server/2 and ibrowse_test_server:stop_server/1 and #81

Closed norton closed 11 years ago

norton commented 11 years ago

xref reports 2 undefined functions.

Can the ibrowse_test.erl module be moved to the test directory? -OR- Can the ibrowse_test_server.erl module be moved to the src directory?

$ git diff
diff --git a/rebar.config b/rebar.config
index a23b6e1..9cbcba9 100644
--- a/rebar.config
+++ b/rebar.config
@@ -1,2 +1,3 @@
 {erl_opts, [debug_info, warn_unused_vars, nowarn_shadow_vars, warn_unused_import]}.
-{eunit_opts, [verbose]}.
\ No newline at end of file
+{xref_checks, [undefined_function_calls, deprecated_function_calls]}.
+{eunit_opts, [verbose]}.

$ ./rebar compile xref
==> ibrowse (compile)
Compiled src/ibrowse_lb.erl
Compiled src/ibrowse_test.erl
Compiled src/ibrowse.erl
Compiled src/ibrowse_app.erl
Compiled src/ibrowse_sup.erl
Compiled src/ibrowse_lib.erl
Compiled src/ibrowse_http_client.erl
==> ibrowse (xref)
src/ibrowse_test.erl:242: Warning unit_tests/1 calls undefined function ibrowse_test_server:start_server/2
src/ibrowse_test.erl:242: Warning unit_tests/1 calls undefined function ibrowse_test_server:stop_server/1
cmullaparthi commented 11 years ago

Probably best to move the ibrowse_test.erl module to the test directory.

On 26 November 2012 07:15, Joseph Wayne Norton notifications@github.comwrote:

xref reports 2 undefined functions.

Can the ibrowse_test.erl module be moved to the test directory? -OR- Can the ibrowse_test_server.erl module be moved to the src directory?

$ git diff diff --git a/rebar.config b/rebar.config index a23b6e1..9cbcba9 100644 --- a/rebar.config +++ b/rebar.config @@ -1,2 +1,3 @@ {erl_opts, [debug_info, warn_unused_vars, nowarn_shadow_vars, warn_unused_import]}. -{eunit_opts, [verbose]}. \ No newline at end of file +{xref_checks, [undefined_function_calls, deprecated_function_calls]}. +{eunit_opts, [verbose]}.

$ ./rebar compile xref ==> ibrowse (compile) Compiled src/ibrowse_lb.erl Compiled src/ibrowse_test.erl Compiled src/ibrowse.erl Compiled src/ibrowse_app.erl Compiled src/ibrowse_sup.erl Compiled src/ibrowse_lib.erl Compiled src/ibrowse_http_client.erl ==> ibrowse (xref) src/ibrowse_test.erl:242: Warning unit_tests/1 calls undefined function ibrowse_test_server:start_server/2 src/ibrowse_test.erl:242: Warning unit_tests/1 calls undefined function ibrowse_test_server:stop_server/1

— Reply to this email directly or view it on GitHubhttps://github.com/cmullaparthi/ibrowse/issues/81.

norton commented 11 years ago

I created a new pull request.

https://github.com/cmullaparthi/ibrowse/pull/82

Marking this as closed.