search

cmullaparthi / ibrowse

Erlang HTTP client
Other
516 stars 190 forks source link

Added Socks5 #96

Closed ghost closed 11 years ago

ghost commented 11 years ago

Hi. I added socks5 support. I implemented all functional of socks5 which used likely all of clients. Socks5 with and without authentication. This patch don't touch much existent code.

Hope this functional is needed not only for me, and good enough to be merged ;)

ghost commented 11 years ago

Domain resolving I implemented only on client side. If also needed implementation on server side - tell me.

cmullaparthi commented 11 years ago

Looks good, thank you! Could you please rename ibrowse_socks5 to ibrowse_socks5 just to keep the naming convention consistent?

cheers Chandru

On 30 June 2013 16:08, presidentua notifications@github.com wrote:

Hi. I added socks5 support. I implemented all functional of socks5 which used likely all of clients. Socks5 with and without authentication. This patch don't touch much existent code.

Hope this functional is needed not only for me, and good enough to be

merged ;)

You can merge this Pull Request by running

git pull https://github.com/presidentua/ibrowse master

Or view, comment on, or merge it at:

https://github.com/cmullaparthi/ibrowse/pull/96 Commit Summary

  • add socks5 support

File Changes

  • M .gitignorehttps://github.com/cmullaparthi/ibrowse/pull/96/files#diff-0(4)
  • M README.mdhttps://github.com/cmullaparthi/ibrowse/pull/96/files#diff-1(15)
  • M src/ibrowse_http_client.erlhttps://github.com/cmullaparthi/ibrowse/pull/96/files#diff-2(8)
  • A src/ibrowser_socks5.erlhttps://github.com/cmullaparthi/ibrowse/pull/96/files#diff-3(57)

Patch Links:

ghost commented 11 years ago

Sorry, didn't notice this typo. Now I fixed it