codecov-commenter
commented
1 year ago Codecov Report
Merging #61 (12f1e5f) into master (9e60787) will increase coverage by
0.02%. The diff coverage is94.44%.:exclamation: Current head 12f1e5f differs from pull request most recent head 2cc3a86. Consider uploading reports for the commit 2cc3a86 to get more accurate results
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@ Coverage Diff @@
## master #61 +/- ##
==========================================
+ Coverage 96.91% 96.94% +0.02%
==========================================
Files 56 56
Lines 3701 3701
==========================================
+ Hits 3587 3588 +1
+ Misses 114 113 -1 | Files Changed | Coverage Δ | |
|---|---|---|
| include/parlay/internal/atomic_wait.h | 100.00% <ø> (+2.56%) |
:arrow_up: |
| include/parlay/internal/delayed/flatten.h | 100.00% <ø> (ø) |
|
| include/parlay/io.h | 94.47% <ø> (ø) |
|
| include/parlay/primitives.h | 99.24% <ø> (ø) |
|
| include/parlay/internal/group_by.h | 92.98% <87.50%> (ø) |
|
| include/parlay/alloc.h | 96.77% <100.00%> (ø) |
|
| include/parlay/hash_table.h | 88.05% <100.00%> (ø) |
|
| include/parlay/internal/block_allocator.h | 95.58% <100.00%> (ø) |
|
| ...nclude/parlay/internal/posix/file_map_impl_posix.h | 100.00% <100.00%> (ø) |
|
| include/parlay/internal/sequence_base.h | 99.28% <100.00%> (ø) |
|
| ... and 4 more |
These are small cleanups that are found by clangs -Weverything. Cleaning them here means that other projects that include parlaylib in them can also compile with these extra warnings without having to selectively disable them.
In addition to the warnings I fixed, here is a set of additional warnings. I did not fix these before asking since they can get a little more opinionated, they are mostly around variable shadowing, changing signedness, and changing precision.
warnings.txt