search

cmuparlay / parlaylib

A Toolkit for Programming Parallel Algorithms on Shared-Memory Multicore Machines
MIT License
321 stars 60 forks source link

Rewrite relocation to be compliant with P1144 #67

Closed DanielLiamAnderson closed 9 months ago

DanielLiamAnderson commented 1 year ago

Relocation now mostly follows the API proposed in P1144. Parlay will also defer the implementation of relocation operations to the compiler/library if they are present, which currently works on Arthur O'Dwyer's LLVM fork here.

codecov-commenter commented 1 year ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9e60787) 96.91% compared to head (3aee6d2) 96.80%. Report is 1 commits behind head on master.

Files Patch % Lines
include/parlay/internal/integer_sort.h 66.66% 2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #67 +/- ## ========================================== - Coverage 96.91% 96.80% -0.12% ========================================== Files 56 57 +1 Lines 3701 3719 +18 ========================================== + Hits 3587 3600 +13 - Misses 114 119 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Quuxplusone commented 9 months ago

@DanielLiamAnderson belated ping! The deadline for P1144R10 is early on February 15th — any chance this PR could be merged by then?

DanielLiamAnderson commented 9 months ago

Oops, yes, I'll try! I just want to finish a little more testing but I'll see if I can do that asap.