Key word updates - Githubissues

Ipswitch commented 7 years ago

I've just downloaded Atom to work with some terraform files and notice some keyword lists are short in the project.

I grep'd the terrrafrom source code, but would leave to you to update the .cson files. There are four patterns and I included the results for two. These caused some issues as the gtksourceview used with xed and gedit highlight functions could not handle a 54k regular expression. I'll leave it up to you.

echo grep -rPo --include \*.go ./builtin -e "(?<=\")[a-zA-Z0-9,_]*(?=\":\W*{)" | cut -d':' -f2 | sort | uniq | sed 's/\n//g' | sed 's/ /|/g'

GiantToast commented 7 years ago

Some things are matched directly, like the list of built in function keywords above (base64encode, etc.). Some things are matched by the form they take.

Is there anything specific you are seeing thats not working?

Rather than trying to match all the keywords exactly, the grammars try to match on the format that Terraform file entries require. For example, instead of matching aws_waf_ipset it attempts to match the form of:

resource "aws_waf_ipset" "name" {
    ...
}

and so on.

If you give me some examples of what is not working as you expect, I'd be happy to take a look. Thanks for the feedback.

Ipswitch commented 7 years ago

I'm new to Atom and misdirected the issue. What I wish to accomplish is done with an autocomplete provider for the Terraform language. Highlighting is OK, hints are better.

autocompleteterraform 2017-02-22 17-01-15

GiantToast commented 7 years ago

Understood, I'll see if I can update the list.

Ipswitch commented 7 years ago

I'm playing with the following to update the language-terraform.cson file. You'll need to clean up captured examples, but it's a start.

for fn in grep -rPo --include \*.go ./builtin -e "((?<=\")[a-zA-Z0-9,_]*(?=\":\W*{))|((?<=\")[a-zA-Z0-9,_]*(?=\":\W*(&schema\.Schema)))|(?<=\")[a-zA-Z0-9,_]*(?=\":\W*(dataSource|resource))" | cut -d':' -f2 | sort | uniq; do echo -e "\t'$fn':\n\t\t'prefix': 'expr substr $fn 1 2'\n\t\t'body': \"$fn\""; done >> language-terraform/language-terraform/settings/language-terraform.cson

Ipswitch commented 7 years ago

A contextual autocomplete is going to take more time than I have. This met the need and didn't break the snippets

git clone git@github.com:hashicorp/terraform.git; echo "'.source.terraform':" > ~/.atom/packages/language-terraform/snippets/keywords.cson; for fn in grep -rPo --include \*.go ./terraform/builtin -e "((?<=\")[a-zA-Z0-9,_]*(?=\":\W*{))|((?<=\")[a-zA-Z0-9,_]*(?=\":\W*(&schema\.Schema)))|(?<=\")[a-zA-Z0-9,_]*(?=\":\W*(dataSource|resource))" | cut -d':' -f2 | sort | uniq; do if ! grep -Fxq " '$fn':" ~/.atom/packages/language-terraform/snippets/snippets.cson; then echo -e " '$fn':\n 'prefix': '$fn'\n 'body': \"$fn\"\n"; fi; done >> ~/.atom/packages/language-terraform/snippets/keywords.cson; rm -rf terraform

GiantToast commented 7 years ago

Thanks for the great suggestion and feedback. I'm slowly working on adding in autocomplete stuff to handle that as my time allows. I'm pretty swamped at work right now, but we'll get it in eventually. Just wanted to say I haven't forgotten about this.

GiantToast commented 7 years ago

After merging in your pull request, is okay if I close this?

cmur2 / language-terraform

Key word updates #26