search

cmur2 / language-terraform

Terraform.io support for Atom
MIT License
49 stars 32 forks source link

Strings not highlighted anymore #53

Open lra opened 3 years ago

lra commented 3 years ago

I use a theme that's supposed to highlight strings (in green): image https://github.com/atom/atom/tree/master/packages/one-dark-syntax

Up to today, it was highlighting strings in terraform too. But not sure what changed today, strings in terraform are not highlighted anymore: Screen Shot 2021-04-14 at 2 54 57 PM

Any idea how to highlight strings back?

Other languages are fine, e.g. python: Screen Shot 2021-04-14 at 2 56 34 PM

It seems specific to this package, and recent.

cmur2 commented 3 years ago

There are no recent updates to this package as seen in the version history: https://github.com/cmur2/language-terraform/releases

Which version of Atom and of the language-terraform package are you using? Maybe we can narrow down what changed :)

lra commented 3 years ago

Yes, that's why I'm asking for help, I don't know what happened =(

$ atom --version
Atom    : 1.56.0
Electron: 9.4.4
Chrome  : 83.0.4103.122
Node    : 12.14.1

Screen Shot 2021-04-14 at 8 49 22 PM

On macOS 11.2.3

craigwatson commented 3 years ago

I can replicate this - I'm using the same versions of all components, and I seem to have lost some of the secondary syntax highlighting for Terraform:

image

image

cmur2 commented 3 years ago

Thanks for both of your input! I will have a look at the problem, whether I can reproduce it and what might be causing it.

My first goto was https://atom.io/releases to check whether it mentions anything noteworthy regarding syntax highlighting changes... nothing obvious to me.

cmur2 commented 3 years ago

I can reproduce the issue locally when updating my Atom from version 1.53.0 to 1.56.0:

Auswahl_1460 Auswahl_1459

Hmmm...

Edit: actually, in Atom version 1.55.0 the highlighting also still works.

cmur2 commented 3 years ago

@lra @craigwatson I'm happy to report that the syntax highlighting works again with no changes on current https://atom.io/nightly (1.58.0-nightly) - the comment https://github.com/atom/atom/issues/22168#issuecomment-817189907 made me try this. Would be great if you can confirm this in case you feel adventurous enough to try the nightly.

So for now I'd recommend downgrading to the last known good Atom version 1.55.0 if you consider the weird highlighting of language-terraform important enough + that's possible for you 🙂

lra commented 3 years ago

Not for me with nightly =( Screen Shot 2021-04-15 at 9 16 37 PM Screen Shot 2021-04-15 at 9 17 18 PM Am I missing something I should do?

craigwatson commented 3 years ago

Also sadly not fixed for me with the latest nightly build:

image

image

craigwatson commented 3 years ago

Confirmed that rolling back to 1.55.0 fixes the problem though:

image

image

cmur2 commented 3 years ago

Given that there is still activity and new reports coming in at https://github.com/atom/atom/issues/22168 I'd not spent further time troubleshooting for now since I realize that the Atom nightly build is a moving target -- it might behave differently every day depending on what upstream does.

Recommendation for now would be going back to 1.55.0 and wait what a release of 1.57.0 and/or 1.58.0 brings.

Fran-Rg commented 3 years ago

Release link: https://github.com/atom/atom/releases/tag/v1.55.0

lra commented 3 years ago

FTR, 1.57.0 just got released and the problem is still happening.

cmur2 commented 3 years ago

FTR, 1.57.0 just got released and the problem is still happening.

@lra looks like the problems still persist with Atom 1.57.0 also for other people, such as https://github.com/atom/atom/issues/22168#issuecomment-841309800

I'm still leaning towards waiting how https://github.com/atom/atom/issues/22168 develops (whether it's a theme issue or a language syntax issue) as it's not clear to me how to proceed. During that time downgrading to Atom 1.55.x is what I'd recommend :/