Closed ghost closed 9 years ago
theonewolf
commented
9 years ago This looks good.
Regarding (4), yes somethings should be more generalized within gammaray. Overtime hoping to revise/refactor it that way. These are artifacts of late night paper experiments mostly! Thanks for all the fixes!
ghost
commented
9 years ago Niceeee wat shud i do for friday? Sth to do with introspection?
On Tuesday, April 21, 2015, Wolfgang Richter notifications@github.com wrote:
Merged #39 https://github.com/cmusatyalab/gammaray/pull/39.
— Reply to this email directly or view it on GitHub https://github.com/cmusatyalab/gammaray/pull/39#event-286400962.
1) Diff works now 2) First problem I fixed was regarding short names, and how I wasn't converting them into appropriate long names. 3) Then, I fixed . and .. entries and now I'm not serializing the . and .. entries. 4) I found that binary files were coming out as different on diff after a cluster and I thought that was weird. It seems that gray-fs had a little bug where we should be dividing the offset by the cluster_size (which is 8192 in this partition of fat32) not by a constant. Double check this for me:)
Thanks!