cmusatyalab / opendiamond

Interactive search of non-indexed data
http://diamond.cs.cmu.edu/
Eclipse Public License 1.0
19 stars 9 forks source link

Premature connection close with detaching transports #38

Open bgilbert opened 11 years ago

bgilbert commented 11 years ago

When a search completes, we immediately close the SockJS connection. When the client is using a detaching transport such as XhrStreamingTransport and it is currently detached, this will drop any unsent messages on the floor (mrjoes/sockjs-tornado#44). If this is not fixed upstream, we can work around it by starting a coroutine that only closes the connection after waiting a while (but not indefinitely) for the Session send_queue to empty.