search

cmusphinx / g2p-seq2seq

G2P with Tensorflow
Other
667 stars 196 forks source link

AssertionError: assert data_dir #198

Open kairosdojo opened 3 years ago

kairosdojo commented 3 years ago

The README file states that, if you want to train a g2p model, you should run g2p-seq2seq with this syntax:

g2p-seq2seq --train train_dictionary.dic --model_dir model_folder_path

Unfortunately this syntax yields the following error:

File "[...]l/g2p_seq2seq/g2p_problem.py", line 238, in dataset
assert data_dir
AssertionError

Fix

Looking closely at https://github.com/cmusphinx/g2p-seq2seq/blob/master/g2p_seq2seq/g2p_problem.py#L238 it's just a matter of adding the folder, apparently.

In fact, this works: g2p-seq2seq --train ./train_dictionary.dic --model_dir model_folder_path

My suggestion is to highlight the need of the directory in the README too.