search

cmusphinx / g2p-seq2seq

G2P with Tensorflow
Other
670 stars 194 forks source link

Raise error if model path is not specified in training #67

Closed gorinars closed 7 years ago

gorinars commented 7 years ago

Currently if user forgot model path, training is going, but the model is not saved

Alternatively we should define a default path

nshmyrev commented 7 years ago

We implemented that for training unit test I believe, we need to think how to test properly then.

nshmyrev commented 7 years ago

What is 'model direction'?

nurtas-m commented 7 years ago

It's a direction where a user suppose to save or restore a model.

gorinars commented 7 years ago

Yes, we should also check if unit test works with such fix. Maybe for the moment raising WARNING would be more correct

nshmyrev commented 7 years ago

Fixed now