cmusphinx / node-pocketsphinx

Pocketsphinx bindings for Node.JS
Other
242 stars 47 forks source link

Use NaN in order to make this compatible with newer version of node #5

Closed Prior99 closed 8 years ago

Prior99 commented 9 years ago

Please note that as of the different getter-setter-api of NaN you will now have to use:

sphinx.search = "..."

instead of

sphinx.search("...")
Prior99 commented 9 years ago

@cmusphinx could this be merged an published to npmjs or at least be commented at for why not being merged?

nshmyrev commented 9 years ago

Thank you for the contribution, I will merge it in few days. I just need to set node and test it myself. There is also an issue with pushing it to npm, I believe I don't have permissions for that, need to figure out how to get ownership over the repository.

Prior99 commented 9 years ago

Thank you.

Prior99 commented 9 years ago

3 weeks later this is sadly still not merged.

nshmyrev commented 8 years ago

Updated to latest node

nshmyrev commented 8 years ago

Thank you very much for contribution!