search

cmusv / pysheetgrader-core

PySheetGrader -- grading spreadsheet assignments made easy!
Other
2 stars 2 forks source link

Negative grading does not work with check rubric type #25

Open erdogmush opened 2 years ago

erdogmush commented 2 years ago

We are getting this type of result, which doesn't make sense (GRRR this should have been tested)!

We get this kind of input, where Row B23 is green (graded as correct) but has a negative score and row C22 is red (graded as incorrect) but has a zero score. The rubrics for these cells both have negative scores and C22 should have a negative score and B23 should have a 0 score. The score assignment appears to be wrong when check rubric is combined with negative grading. However in test-mode, the corresponding tests pass. I think this is because the correct/incorrect label is right, but the score assignment is wrong.

ID Cell Description Score Max Feedback Rubric Type Error
B10 None 0 1.0 Hmmm - result should be 3.5637059362410923 +/- 0.1! Result check  
C11 None 0 1.0   Result check  
B12 None 1.0 1.0   Result check  
C13 None 0 1.0   Result check  
B14 None 1.0 1.0   Result check  
C15 None 0 1.0   Result check  
B16 None 1.0 1.0   Result check  
B17 None 1.0 1.0   Result check  
C18 None 0 1.0   Result check  
C20 None 0 1.0   Result check  
C22 None 0 0   Result check (penalty)  
B23 None -2.0 0   Result check (penalty)  
Grade for sheet: RCheck 2.0 10.0
colelloa commented 1 year ago

issue was fixed by incorporating check rubric in larger template pattern that handled negative grading properly