search

cmv / cmv-app

CMV - The Configurable Map Viewer - A community supported open source mapping framework built with the Esri JavaScript API and the Dojo Toolkit
https://demo.cmv.io/
MIT License
323 stars 278 forks source link

support arcgis javascript api v3.33? or v3.28 #966

Closed hoogw closed 3 years ago

hoogw commented 3 years ago

support arcgis javascript api v3.33? or v3.28

tmcgee commented 3 years ago

@hoogw

The current version we support is v3.33. Most prior versions over the last several years will work as well.

hoogw commented 3 years ago

Thanks, I use v3.28 all the time until last week, I suddenly found 2 year running CMV (with 3.28) broken The error message is below

image

I try change index.html ( v3.28 to v3.33), same error, looks like I need completely re-build to upgrade to v3.33

hoogw commented 3 years ago

I found the reason, it is because, 2 year ago, zoom level support decimal. for example, I set zoom=16.7, it works fine.

Recently error is because recently, either CMV change code, or ESRI v3.28/v3.33 change code, will NOT support zoom=16.7, you must use zoom=17 integer only.

If I continual use zoom=16.7, will cause above error.

tmcgee commented 3 years ago

@hoog That would definitely be change in ESRI code, not CMV. I am surprised that non-decimal zoom levels were ever allowed. This is the first time I recall anyone attempting to use them. Glad you got it worked out. 👍🏽