search

cmv / cmv-wab-widgets

Examples of using widgets from the ESRI WebApp Builder in CMV
https://cmv.github.io/cmv-wab-widgets/demo.html?config=wab
MIT License
9 stars 19 forks source link

CMV Editor widget issue in WAB enabled cmv viewer since api 3.21 #30

Closed ERS-Long closed 6 years ago

ERS-Long commented 6 years ago

Today a user reported to us this issue, if we update the viewer to 3.25, then the CMV editor widget stops working, the error popup is 

Uncaught RangeError: Maximum call stack size exceeded

If we switch back to 3.21, it still works, tried 3.22, 3.23, 3.24, 3.25, and 3.26, all failed. Please see if you experienced the same or not, any suggestion on how to fix this issue.

Thanks!

tmcgee commented 6 years ago

@ERS-Long Which version of CMV and which version of Web App Builder?

ERS-Long commented 6 years ago

I tried most current CMV (3.26) with WAB 2.9. (if change api from 3.26 to 3.21, then no error).

Thanks,

tmcgee commented 6 years ago

@ERS-Long Are you using the CMV Identify widget with:

defaultMapClickMode: 'identify',

in the config. file?

Changes in the Esri Editor Toolbar are causing the endless recursion. It is in confict with this section of the WAB Mixin. Presently, I don't have a work-around for all cases. But if you are not using identify, you can possibly solve this by removing the defaultMapClickMode or commenting out the section of code in the MixIn. I can verify this solves the issue but may not be acceptable for your application.

ERS-Long commented 6 years ago

@tmcgee Got it, that is why. Yes, I can comment out the wab mixin map click section code.

Thanks for your tip, as aways, it just works!!

:)

tmcgee commented 6 years ago

@ERS-Long When using this cmv-wab-widgets, another consideration is to use the WAB Edit widget. It doesn't work in the current version of cmv-wab-widgets for reasons not directly related to the Edit widget itself. Thanks to your question, I have explored the issue and have the Edit widget working locally. 😄

ERS-Long commented 6 years ago

Good to know, try to stay away from default WAB widgets as far as possible, use them only when i have to as the last resort. :) That being said, I tried to load the WAB default edit widget in, no luck, when you have time if you could share your trick to get that work in CMV, that will be great. But not urgent, only when you have time. Thanks!

tmcgee commented 6 years ago

@ERS-Long The Smart Editor widget is another more "evolved" WAB widget for editing. It is a newer widget so is more robust than the WAB and CMV Editor widgets that rely on the antiquated Esri Editor Toolbar.

I have that widget working as well.

Some time soon, I will commit the changes into this repo to allow these widgets to work.