cmweiss / geomag

Automatically exported from code.google.com/p/geomag

45 stars 43 forks source link

Refactor to be more pythonic #7

Open sposs opened 7 years ago

cmweiss commented 7 years ago

Thanks, I'll take a look at your pull request in detail. It may take me a few days to dig in. Would you please give me a bit more detail on your changes. More pythonic is nice to know but I need more explanation, please.

sposs commented 7 years ago

I moved the things around (split code and tests), changed the package structure to make it more standard, as there was an unnecessary level. I also fixed some PEP8 conventions. I simplified operations (a = a+1 becomes a += 1). Nothing else.

sposs commented 7 years ago

3 is much better than this one...