search

cmzuo11 / scMVAE

Deep joint-leaning single-cell multi-omics model
16 stars 0 forks source link

Questions regarding unused arguments #3

Open wehos opened 2 years ago

wehos commented 2 years ago

Hi,

Thanks for the awesome package! Your paper is very impressive. I just notice a strange thing in your codes: https://github.com/cmzuo11/scMVAE/blob/a4e997242835b8d601b1ac4bea552e3d2bd306fa/scMVAE/MVAE_model.py#L652-L653

Here, arguments local_l_mean1 and local_l_var1 have never been used, while line 670 and line 679 (see codes below) are using the same variables local_l_mean and local_l_var for both X1 and X2. Could you please double check whether this is consistent with your original design? Thanks!

https://github.com/cmzuo11/scMVAE/blob/a4e997242835b8d601b1ac4bea552e3d2bd306fa/scMVAE/MVAE_model.py#L665-L683

Best, Hongzhi

cmzuo11 commented 2 years ago

Thanks for your question. I have checked my previous code in the sever. This is a typo when I organize my code. I have revised it.

Best