search

cn-terraform / terraform-aws-ecs-fargate

AWS ECS Fargate Terraform Module
https://registry.terraform.io/modules/cn-terraform/ecs-fargate
Apache License 2.0
87 stars 57 forks source link

Changing submodule variables #8

Closed advissor closed 4 years ago

advissor commented 4 years ago

Hi,

I've been using the module and everything bootstraps like a charm out of the box. Though, I have difficulties settings some of the related submodule settings.

Do you have any examples of changing lb_target_group "deregistration delay" or LB timeout values from inside your top module implementation?

And in general, how do you advise to alter the related module features which are not available as input?

Thanks and Regards, Vlad

jnonino commented 4 years ago

Hi, I'll start working on that today and let you know as soon as I have it done.

advissor commented 4 years ago

Hi, Any intermediate results or ideas on how to achieve this goal you can share ? :)

jnonino commented 4 years ago

I have created a new version of the module. It has a lot of extra variables. Please test it and let me know if that works for you. New version: 2.0.11

advissor commented 4 years ago

Thanks a lot @jnonino ! Will start testing it and will let you know how it goes :)

jnonino commented 4 years ago

Im made some extra corrections to the module on a new version.

advissor commented 4 years ago

@jnonino i see some options missing also like log configuration Can this be added ?

log_configuration = { logDriver = "awslogs" options = { awslogs-group = "xxxxxxx" awslogs-region = "xxxxxxx" awslogs-stream-prefix = "xxxxxxx" } secretOptions = [] }

I used to pass it like this in version 2.09 Is it still configurable?

jnonino commented 4 years ago

Added in version 2.0.13. Everything else is working without issues?