search

cn-terraform / terraform-aws-ecs-service-autoscaling

AWS ECS Service Autoscaling
https://registry.terraform.io/modules/cn-terraform/ecs-service-autoscaling/aws/
Apache License 2.0
15 stars 18 forks source link

Email when service autoscales and / or alarm triggers #28

Closed dkatzz closed 6 months ago

dkatzz commented 1 year ago

It would be nice if there was an optional email variable that could be set, so that the email provided could get notified when the service autoscales or the alarm triggers. This could also be done by having a variable for a sns topic arn if that is easier and if set it gets added to the alarm actions as well.

mayank0202 commented 6 months ago

https://github.com/cn-terraform/terraform-aws-ecs-service-autoscaling/pull/31

I have added sns variable as an optional variable so that should work @dkatzz @jnonino

jnonino commented 6 months ago

Hi @dkatzz and @mayank0202, considering the change by @mayank0202 released in version 1.0.7. Do you think we can close this issue?

mayank0202 commented 6 months ago

We can close this issue after merging this PR https://github.com/cn-terraform/terraform-aws-ecs-service-autoscaling/pull/32 Its tested on aws

mayank0202 commented 6 months ago

@jnonino We can close this issue , its working fine . please use 1.0.8 version

jnonino commented 6 months ago

Thank you!!!

dkatzz commented 6 months ago

Thank you for making these changes!!