search

cn-uofbasel / ccn-lite

CCN-lite, a lightweight implementation of the CCNx protocol and its variations
ISC License
74 stars 63 forks source link

adds unit tests for ccnl-pkt-util #311

Closed mfrey closed 6 years ago

mfrey commented 6 years ago

Contribution description

Adds unit tests for various functions from ccnl-pkt-util.{c,h}.

mfrey commented 6 years ago

I'm not really happy about the test_ccnl_pkt2suite_valid. I've tried to generate an interesst via "ccn-lite-mkI" and used that as value for the data parameter (I've piped the output of the command through hexdump), but doing this actually causes a segfault. I left the code in the test (it is commented out) in order to discuss it.

In any case, the dead code needs to be removed before this PR gets approved/merged.

mfrey commented 6 years ago

@blacksheeep Just removed the dead code from test_pkt-util.c. Please re'ack