search

cn-uofbasel / ccn-lite

CCN-lite, a lightweight implementation of the CCNx protocol and its variations
ISC License
74 stars 63 forks source link

Fixes #334

Closed blacksheeep closed 5 years ago

blacksheeep commented 5 years ago

This pull request should fix some of the problematic typing problem and other potentional security fixes

Contribution description

Fix, Type Confusions, Unsafe Function Calls,...

mfrey commented 5 years ago

You shouldn't update your feature branch by merging your master into the feature branch, but by using fetch/rebase. Doing otherwise is considered bad style.

mfrey commented 5 years ago

I suggest to make a clean new feature branch and cherry-pick the corresponding commits over to the new (clean) branch.

blacksheeep commented 5 years ago

Currently CCN-Lite is not C99 compiled, which causes an error when compiling for loops with iterator defined in the for loop

blacksheeep commented 5 years ago

I suggest to make a clean new feature branch and cherry-pick the corresponding commits over to the new (clean) branch.

How important is this, in case we squash the commits anyway?