cn10xdev / ECommerce_Product_Page

1 stars 24 forks source link

Add to Cart Button Doesn't Update Correctly #1 #14

Open Maheshh-Busam opened 1 month ago

Maheshh-Busam commented 1 month ago

For Issue :

  1. Add to Cart Button Doesn't Update Correctly Closes #1

Updated the code logic to update the item price as per the number of items added (item's quantity)

Ezio-Sarthak commented 1 month ago

Hi @Maheshh-Busam it's always a good practice to create separate PRs for issues to resolve, when the code changes are different, although the commits are different for those features.

Also, please refrain from closing PR on your own, we're here to do that task 👍

Ezio-Sarthak commented 1 month ago

One more thing to note @Maheshh-Busam , there's a scope for improvement on your commit message. Whenever making a commit have something like:

bugfix: Add to Cart button fixed A short commit description

This way whenever someone reviews your code it gives a brief picture of how the code change looks like

Maheshh-Busam commented 1 month ago

Sure @Ezio-Sarthak , Noted these points. Thanks for your suggestions..

Ezio-Sarthak commented 1 month ago

Could you please re-open this PR?

Maheshh-Busam commented 1 month ago

Okay sure.. I'm reopen this PR.

Maheshh-Busam commented 1 month ago

By mistakenly, I have committed and pushed the 2 issues in same PR. That's why I closed this. And created seperately for each issue..

Ezio-Sarthak commented 1 month ago

It's fine, you can use this PR for one of the issues and create another for other one 👍

Maheshh-Busam commented 1 month ago

@Ezio-Sarthak , Updated this PR