Improvement of UI and toggle Theme feature

Ninad100 commented 1 month ago

Hi I have picked the issue for the improvement of UI. I have applied the changes and requesting pull request to verify.

If any questions or modifications or suggestion then kindly let me know. PFB attached screenshots:

Ninad100 commented 1 month ago

Related to #10

Ninad100 commented 1 month ago

Linking to #12

Ezio-Sarthak commented 1 month ago

Thanks for working on this @Ninad100 ! Before jumping into the review here are few things I wish to convey:

It's a fix that I was supposed to do while creating the repo, but could you please add a gitignore file with node_modules, build folder added. Right now I see 5000+ file changes.
I see your commit messages are duplicated, for me that means the code changes are related for both commits. If so, kindly merge the two commits to a single one. If not, change the commit title.
Please try to add commit description to all commits.
The Dark mode feature has a separate issue created for it. I know it would ideally come under the UI enhancement, but I feel it'd be good to have a separate PR for that as the issue is separate too. I don't think it'd be much of a problem to separate that dark theme logic?

Kindly go through these comments and let me know 👍

Ezio-Sarthak commented 1 month ago

Hi @Ninad100 kindly rebase this branch against the latest main as it is showing some merge conflicts. I've mentioned the steps for rebasing in the disccussions channel 👍

cn10xdev / ECommerce_Product_Page

Improvement of UI and toggle Theme feature #21