cn10xdev / ECommerce_Product_Page

1 stars 24 forks source link

lots of functionality fixed in product and cart #24

Open SOURABHs23 opened 1 month ago

SOURABHs23 commented 1 month ago

https://drive.google.com/file/d/1r8dNu39SWb4ZCMsfx_eFNbCBcXWNyBlV/view?usp=sharing

i have attached the google drink link, where i showed the changes made.

Ezio-Sarthak commented 1 month ago

Thanks for opening this @SOURABHs23

Before jumping into the actually review, I realized there are few things I wished to talk about:

SOURABHs23 commented 1 month ago

yeah got the point, actually i am adding zero after 1, so it will be 10 and it greater than 5 so coming out of stock

https://drive.google.com/file/d/1Pe3GYHBesXXlcOu0O-RJ360vI02h8rag/view?usp=sharing

please check the vedio

SOURABHs23 commented 1 month ago

its another vedio explaining that bug

Ezio-Sarthak commented 1 month ago

Hi @SOURABHs23 apologies for the delayed response! Kindly rebase this branch against the latest main as it is showing some merge conflicts. I've mentioned the steps for rebasing in the discussions channel 👍

SOURABHs23 commented 1 month ago

@Ezio-Sarthak please check now good to merge ? i dont know what i did

Ezio-Sarthak commented 1 month ago

Hi @SOURABHs23 please remove the merge conflicts as I stated in the comment, and please avoid creating unwanted commits while rebasing 👍

SOURABHs23 commented 1 month ago

@Ezio-Sarthak Sir, please check, its fine now?