search

cn10xdev / ECommerce_Product_Page

1 stars 24 forks source link

redux implemented in this project #37

Open yogeshjaguri opened 1 month ago

yogeshjaguri commented 1 month ago

i have implemented redux in this project.

Yash621 commented 1 month ago

@yogeshjaguri thanks for the PR, can you pls refer to this https://github.com/cn10xdev/ECommerce_Product_Page/pull/34 for , how you can mention the PR description and attach some live demos too ?

Yash621 commented 1 month ago

@yogeshjaguri not really sure what was the reasoning behind redux here? can you pls add some more context for it in the PR description on the exact need for it and why can't we go for a simpler solution instead ? redux is a big library which can certainly increase our bundle size while deployment which affects the app performance in the longer run, so we want to keep to it a lean as possible!

Ezio-Sarthak commented 1 month ago

Hi @yogeshjaguri apologies for the delayed response! Kindly rebase this branch against the latest main as it is showing some merge conflicts. I've mentioned the steps for rebasing in the discussions channel 👍