search

cn10xdev / react-express-starter

A basic Boilerplate for React (Front-end) and Server (Back-end) rendering
MIT License
0 stars 5 forks source link

Incorrect window.location Usage in Service Worker Registration #1

Open cn10xdev opened 3 weeks ago

cn10xdev commented 3 weeks ago

In the register function, the service worker URL is constructed using window.location instead of window.location.href. This can cause issues, as window.location is not the correct value to use in this context. This issue needs to be fixed without revealing the correct approach.

mdmoghnishah commented 1 week ago

could you assign it to me