cnabio / cnab-go

A Go implementation of CNAB Core 1.0
MIT License
69 stars 37 forks source link

[spec compliance] Validate installation names correctly #126

Open jlegrone opened 5 years ago

jlegrone commented 5 years ago

The spec says

Installation names MUST consist of Graph Unicode characters and MAY be user-readable. The Unicode Graphic characters include letters, marks, numbers, punctuation, symbols, and spaces, from categories L, M, N, P, S, Zs.

The current test cases do not quite line up with this:

https://github.com/deislabs/cnab-go/blob/fae945b60a78d539434da178ae5c8e212f2977da/claim/claim_test.go#L49-L60

As noted in https://github.com/deislabs/cnab-go/pull/119/files#r324850692