search

cnabio / cnab-go

A Go implementation of CNAB Core 1.0
MIT License
69 stars 37 forks source link

feat(*): populate applicable output values with defaults when necessary #129

Closed vdice closed 5 years ago

vdice commented 5 years ago

If an applicable output (read: applies to a given action) is missing after the operation completes, supply an entry with the output's default value, if/when the default exists.

Note that this has only been added to the Docker driver which appears to be the sole driver implementing outputs as of writing. (edit: we can/should update the command driver once https://github.com/deislabs/cnab-go/pull/130 lands, either here or in a follow-up, depending on timing.)

Closes https://github.com/deislabs/cnab-go/issues/122

vdice commented 5 years ago

The most recent commit was to address the following bit in the spec: Otherwise the runtime should report the missing output as an error to the user. https://github.com/deislabs/cnab-go/pull/129/commits/187c8aa8948e2e966c91ed183815636b88e585ad