search

cnabio / cnab-go

A Go implementation of CNAB Core 1.0
MIT License
69 stars 37 forks source link

Fix for missing k8s logs #137

Closed jzh0u closed 5 years ago

jzh0u commented 5 years ago

Fix for the missing pod logs in the kubernetes driver.

We didn't check to make sure io.Copy() was writing anything, so sometimes it would finish before the pod actually wrote anything. Added a few checks to remedy this.

To reproduce bug: Run go test -tags=integration -count=20 ./driver/kubernetes See below fail at least once image

msftclas commented 5 years ago

CLA assistant check
All CLA requirements met.

glyn commented 5 years ago

@jzh0u Thanks for trying again, but the logic is becoming pretty convoluted. It might be best to try to strip it down to the absolute minimum required to fix the problem.

Also, regardless of this PR, you've found a valid bug, so it would probably be helpful to submit an issue.

glyn commented 5 years ago

@vdice Please could you advise what's gone wrong with the tests check? I can't find any way to debug this.

radu-matei commented 5 years ago

/brig run

glyn commented 5 years ago

@jzh0u Please note your fix will appear in https://github.com/deislabs/duffle/releases/tag/0.3.5-beta.1 which should be available soon (the release is built automatically off the tag).