search

cnabio / cnab-go

A Go implementation of CNAB Core 1.0
MIT License
69 stars 37 forks source link

Follow up: Simplify Docker Driver CLEANUP_CONTAINERS config #141

Open silvin-lubecki opened 5 years ago

silvin-lubecki commented 5 years ago

As a follow-up: The CLEANUP_CONTAINERS config can be simplified if we invert the semantic of the key, with something like KEEP_CONTAINERS. See https://github.com/deislabs/cnab-go/pull/139#pullrequestreview-297143365 .

Also the driver shouldn't print on the standard output without a way to disable it. See https://github.com/deislabs/cnab-go/pull/139#discussion_r331246080 . I guess that with the simplification proposed above this warning could be removed.

jeremyrickard commented 5 years ago

🖖 Thanks @silvin-lubecki