search

cnabio / cnab-go

A Go implementation of CNAB Core 1.0
MIT License
69 stars 37 forks source link

Difficulty with transitive dependencies while bumping ggcr #157

Closed glyn closed 4 years ago

glyn commented 4 years ago

This draft PR is evidence of the need for https://github.com/deislabs/cnab-go/issues/156.

carolynvs commented 4 years ago

I had a conversation with @radu-matei on his other PR https://github.com/deislabs/cnab-go/pull/150/files#r340859692 about how to properly manage dependencies. If you want to manage transitive dependencies with dep, that is how to do it.

glyn commented 4 years ago

I had a conversation with @radu-matei on his other PR https://github.com/deislabs/cnab-go/pull/150/files#r340859692 about how to properly manage dependencies. If you want to manage transitive dependencies with dep, that is how to do it.

Thanks. Although that may be a necessary workaround with dep, it's not ideal because we then have to manually maintain the transitive dependencies and line them up accurately. I think that's reason enough alone to spur us on to go modules, which isn't that painful actually.

squillace commented 4 years ago

@glyn you, of course, realize that once you say something's not very painful, you end up being the sole point of responsibility, right? :-)

carolynvs commented 4 years ago

I'm just sharing what we can do today, if we aren't ready to jump the 🦈 and switch 15+ repos over to modules in a weekend. I am painfully aware that dep was killed before transitive dependency support was added...

If the group would like to move to modules immediately, I am not going to stand in their way but I will wait for someone else to volunteer. 😀

glyn commented 4 years ago

Thanks @carolynvs. When we move to modules, I propose we start on a Monday. Let's plan to keep our weekends for rest. :-)

jlegrone commented 4 years ago

@glyn is this still needed now that #161 is merged?