fix(docker.go): check nil pointer case; export ApplyConfigurationOptions

cnabio / cnab-go

A Go implementation of CNAB Core 1.0

MIT License

69 stars 37 forks source link

fix(docker.go): check nil pointer case; export ApplyConfigurationOptions #205

Closed vdice closed 4 years ago

vdice commented 4 years ago

Avoids nil pointer panic if configuration uninitialized at time of retrieval
Exports ApplyConfigurationOptions method, handy for consumers of this pkg

Q for reviewers: Should we explicitly error out if the configuration is uninitialized? Or return an empty struct and no error, as is currently done in this PR?

vdice commented 4 years ago

Closing this as I think I'll put up a replacement PR wherein the container config fields on the Driver object are no longer pointers... simplifies logic and is much more consumer-friendly.