update config fields on Driver struct to not be pointers
When consuming the latest code for use in Porter (to add tests around Porter's configuration options in this area), I found it problematic that some struct fields were pointers (containerCfg and containerHostCfg). I started to go down the path of creating methods in this library to return default Driver objects (NewDriver() would return a Driver with initialized/empty field references) but then I realized perhaps the code simplifications and ease of use that came with switching the fields to be actual values would be warranted here. What do reviewers think? Is there Golang best practice w/r/t fields in structs being pointers? (Avoid? Only use if initializer method(s) are provided?)
export ApplyConfigurationOptions
Porter will use this method to apply its configuration options without having to call exec on the driver in unit tests
update config fields on Driver struct to not be pointers
containerCfg
andcontainerHostCfg
). I started to go down the path of creating methods in this library to return default Driver objects (NewDriver()
would return aDriver
with initialized/empty field references) but then I realized perhaps the code simplifications and ease of use that came with switching the fields to be actual values would be warranted here. What do reviewers think? Is there Golang best practice w/r/t fields in structs being pointers? (Avoid? Only use if initializer method(s) are provided?)export ApplyConfigurationOptions
exec
on the driver in unit tests