cnabio / cnab-go

A Go implementation of CNAB Core 1.0
MIT License
69 stars 37 forks source link

Stop on nonzero exit code #213

Closed carolynvs closed 4 years ago

carolynvs commented 4 years ago

When you embed bash in yaml, make sure to stop on nonzero exit codes. Otherwise builds pass when they should have failed...

Signed-off-by: Carolyn Van Slyck carolyn.vanslyck@microsoft.com

carolynvs commented 4 years ago

Alrighty! I've managed to get the build showing red when it's really broken (which has been for a while) and then fix it...

go mods shenanigans were involved. Don't ask why go mods download was necessary and just building directly pulled down the wrong package. I'm guessing it has something to do with the tides and packr force pushing a tag? 🤷‍♀️