ref(*): extract set, source, strategy and place into valuesource

cnabio / cnab-go

A Go implementation of CNAB Core 1.0

MIT License

69 stars 37 forks source link

ref(*): extract set, source, strategy and place into valuesource #219

Closed vdice closed 4 years ago

vdice commented 4 years ago

Refactor to generalize the Set, Source and Strategy structs so that they can be used for other sets needing source value resolution, such as parameter sets.

Ref https://github.com/deislabs/porter/pull/1068

carolynvs commented 4 years ago

Sorry just realized this is still in draft. Are there more changes to be made?

vdice commented 4 years ago

Rebased off the latest changes. Note I also added the following commit: https://github.com/cnabio/cnab-go/pull/219/commits/581ddfb876a10058004c3941d3757e096728fcce

This updates the invalid source verbiage to be more general, as the source value may not be for a credential (e.g. it could be for a parameter, as can be the case in Porter).

carolynvs commented 4 years ago

I've been using this code in a test branch of Porter for a couple weeks now and it's been working well 👍