cnabio / cnab-go

A Go implementation of CNAB Core 1.0
MIT License
69 stars 37 forks source link

Add Parameter Set #230

Closed vdice closed 2 years ago

vdice commented 4 years ago

Porter implemented Parameter Sets, a correlate for parameters to the Credential Set originally defined in the cnab-spec repo and its golang implementation existing here in this repo. This issue is therefore around migrating the re-usable Parameter Set definition(s) and methods into this library for the broader community to use.

carolynvs commented 4 years ago

It seems to me that unless we change the schema for credentialsets to be generic, there will need to be two schema: one for each. So parameters' schemaVersion would be cnab-parametersets-1.0.0-DRAFT-* and credentials would be cnab-credentialsets-1.0.0-DRAFT-*.

I'm not sure consolidating them together and causing the breaking change for such little value is worth it.

vdice commented 4 years ago

I started on this but realized we'd want to get https://github.com/cnabio/cnab-go/pull/229 in first. (Porter currently references code from the branch in 229, including some of the files intended for porting over to this library.)

carolynvs commented 2 years ago

Closing since we've since changed direction about putting non-runtime concerns into cnab-go.