cnabio / cnab-go

A Go implementation of CNAB Core 1.0
MIT License
69 stars 37 forks source link

K8s driver improvements #238

Closed carolynvs closed 3 years ago

carolynvs commented 3 years ago

I am working on a Porter Operator that can run CNAB bundles using K8s CRDs. As part of that I had to make some changes to the Kubernetes driver to get real (not sample) bundles to work.

With these changes I am able to run @squillace 's kubeflow bundle! 🎉

apiVersion: porter.sh/v1
kind: Installation
metadata:
  name: kubeflow
spec:
  reference: "ghcr.io/squillace/aks-kubeflow-msi:v0.1.7"
  action: "install"
  credentialSets:
    - aks

Closes #73

carolynvs commented 3 years ago

requiredCompletions was not exported, so there wasn't any way to set it to anything other than 1. So we had this configurability in place but there was no way to use it (in addition to it not making any sense to change either).